-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Yarn Berry compatibility flag #1012
Conversation
@eirslett , any feedback on this PR ? |
Can we somehow auto-detect |
That's a nice suggestion.
Would that be OK with you ? If it is, I will update the PR with that implementation |
I don't even think we need the force enable/disable. We could add it later on, if anybody really needs it (which I highly doubt). My concern is to keep the number of configuration parameters in the plugin as low as possible. |
Changes done. |
...in/src/main/java/com/github/eirslett/maven/plugins/frontend/mojo/InstallNodeAndYarnMojo.java
Show resolved
Hide resolved
thanks! |
> yarn set version stable main(origin/main)
➤ YN0000: Retrieving https://repo.yarnpkg.com/3.6.3/packages/yarnpkg-cli/bin/yarn.js
➤ YN0000: Saving the new release in .yarn/releases/yarn-3.6.3.cjs
➤ YN0000: Done in 0s 441ms It downloads the js locally. Instead of pre-installing a version of yarn, why not just directly downloading the 2.x+ version from this repo: This would make installation consistant with the other versions configs? |
Summary
Fixes #928.
Added a compatibility flag for Yarn 2.x and above (Berry) so maven-frontend-plugin doesn't consider reported version as invalid anymore and doesn't try to re-install Yarn every time it runs.
Tests and Documentation
Updated CHANGELOG.md and README.md with details about the new flag